fix(lsp): walk all expression variants when collecting hints 🔍#136
Merged
Conversation
The AST walker had a `_ => {}` catch-all that skipped Call, List, Tuple,
Map, Logical, Assignment, OpAssignment, and range expressions, so any
lambda nested inside those never fired `on_function_declaration` — losing
its return-type inlay hint. The analyser was already computing the type;
the LSP just never reached the node.
Make the match exhaustive so a new Expression variant produces a compile
error instead of a silent regression, and walk into Lvalue::Index for the
same reason.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8113c70e4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
walk_expressionhad a_ => {}catch-all that skippedCall,List,Tuple,Map,Logical,Assignment,OpAssignment, and the range variants — so any lambda nested inside those (e.g.[1,2,3].map(fn(y) => y / 2.0)) never firedon_function_declarationand lost its return-type inlay hint, even though the analyser had already computed the type.Expressionvariant produces a compile error instead of silently regressing visitor coverage.Lvalue::Index { value, index }for the same reason — its child expressions could also hide a lambda (e.g.m[f(fn(x) => x)] = 1).Test plan
cargo test -p ndc_lsp— existing inlay-hint tests pass; two new regression tests pass (lambda_inside_call_gets_return_type_inlay,lambda_inside_list_literal_gets_return_type_inlay).cargo test— full suite green.cargo fmt,cargo clippy -p ndc_lsp— no new warnings introduced.test.ndcin an editor with the LSP attached; the inner lambda in[1,2,3].map(fn(y) => y / 2.0)shows a-> Numberinlay hint.Note: the lambda's return type displays as
Number(notFloat) becauseyis unannotated and the analyser LUBs all/overloads. Sharpening that result is follow-up work in the analyser/dispatch logic, not in scope here.🤖 Generated with Claude Code